From: Junio C Hamano <gitster@pobox.com>
To: Wincent Colaiuta <win@wincent.com>
Cc: git@vger.kernel.org, dzwell@gmail.com, peff@peff.net,
Matthieu.Moy@imag.fr
Subject: Re: [PATCH] Highlight keyboard shortcuts in git-add--interactive
Date: Sun, 02 Dec 2007 11:06:43 -0800 [thread overview]
Message-ID: <7veje4ykzg.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <5B4BC281-10BD-437F-A956-EEB73F40A76C@wincent.com> (Wincent Colaiuta's message of "Sun, 2 Dec 2007 15:11:24 +0100")
Wincent Colaiuta <win@wincent.com> writes:
> Unless by "documentation" you meant to somehow expose these in the
> interface at runtime... something like this? (applied on top of the
> patch I just sent to the list):
I did not recall (and was too lazy to check) if they were documented
already, but as you suggest, I think letting people type ? at the prompt
to get a help is always a good idea. So, instead of doing this part:
> @@ -308,7 +309,7 @@ sub list_and_choose {
> print "> ";
> }
> else {
> - print ">> ";
> + print " (?)>> ";
I'd prefer accepting '?' as a valid "help me" input and showing
appropriate help for _both_ singleton select and multiple select,
without mentioning " (?)". For this, your prompt_help_cmd needs to be
enhanced to limit the help to singleton case, though.
next prev parent reply other threads:[~2007-12-02 19:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 14:27 [PATCH] Highlight keyboard shortcuts in git-add--interactive Wincent Colaiuta
2007-11-21 14:32 ` Matthieu Moy
2007-11-21 15:28 ` Jeff King
2007-11-21 23:00 ` Dan Zwell
2007-11-28 23:56 ` Junio C Hamano
2007-11-29 1:08 ` Wincent Colaiuta
2007-11-29 12:00 ` Wincent Colaiuta
2007-11-29 14:51 ` Jeff King
2007-12-01 2:36 ` Junio C Hamano
2007-12-01 13:58 ` Wincent Colaiuta
2007-12-01 14:07 ` [PATCH 1/2] " Wincent Colaiuta
2007-12-01 14:07 ` [PATCH 2/2] Teach git-add--interactive to highlight untracked file prefixes Wincent Colaiuta
2007-12-01 14:15 ` [PATCH 1/2] Highlight keyboard shortcuts in git-add--interactive Wincent Colaiuta
2007-12-01 14:29 ` [REPLACEMENT PATCH] " Wincent Colaiuta
2007-12-02 14:11 ` [PATCH] " Wincent Colaiuta
2007-12-02 19:06 ` Junio C Hamano [this message]
2007-12-03 8:09 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7veje4ykzg.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@imag.fr \
--cc=dzwell@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).