From: Junio C Hamano <gitster@pobox.com>
To: David Kastrup <dak@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] contrib/emacs/vc-git.el: various improvements.
Date: Sun, 15 Jul 2007 20:20:56 -0700 [thread overview]
Message-ID: <7vejj9avaf.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 403842ba71506c7b194812cd9a4f669c847eb7bc.1184548803.git.dak@gnu.org
David Kastrup <dak@gnu.org> writes:
> (vc-git-symbolic-commit): Simplify and make it return
> something useful in almost all cases.
It would be easier to review and understand if "something
useful" were more specific.
It appears that the previous version of this function tried not
to barf if it got nil or false as input but now it does not seem
to worry about that case. Also the option given to name-rev is
different which would lead to different behaviour -- arguably a
better one, but that needs to be documented in the log message.
> (vc-git-previous-version): Simplify.
> (vc-git-next-version): Simplify and make more efficient.
If you make the result symbolic using vc-git-symbolic-commit, do
you need to add --abbrev/--abbrev-commit to these functions?
These options have very small but still non zero cost.
> (vc-git-annotate-command): heed REV argument.
> (vc-annotate-extract-revision-at-line): Activate.
Ok.
next prev parent reply other threads:[~2007-07-16 3:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 1:24 [PATCH] contrib/emacs/vc-git.el: various improvements David Kastrup
2007-07-15 9:46 ` [PATCH] contrib/emacs/Makefile: Also install .el files David Kastrup
2007-07-16 1:27 ` [PATCH] contrib/emacs David Kastrup
2007-07-16 3:20 ` [PATCH] contrib/emacs/Makefile: Also install .el files Junio C Hamano
2007-07-15 23:42 ` [PATCH] Make several improvements and get annotations to work (Emacs support pending) David Kastrup
2007-07-15 23:53 ` [PATCH] vc-git: support asynchronous annotations, and improve versioning David Kastrup
2007-07-16 3:20 ` Junio C Hamano
2007-07-16 5:29 ` David Kastrup
2007-07-16 6:14 ` Junio C Hamano
2007-07-16 0:05 ` [PATCH] (vc-git-annotate-command): Make synchronous for now David Kastrup
2007-07-16 3:20 ` Junio C Hamano [this message]
2007-07-16 5:26 ` [PATCH] contrib/emacs/vc-git.el: various improvements David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vejj9avaf.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).