Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff-options: add --stat
Date: Wed, 12 Apr 2006 23:53:44 -0700	[thread overview]
Message-ID: <7vek02ynif.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vy7ya13e3.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Wed, 12 Apr 2006 21:54:44 -0700")

Junio C Hamano <junkio@cox.net> writes:

> I wonder if you can also make this an independent option that
> prepends diffstat in front of the patch, just like the way the
> new flag --patch-with-raw flag prepends raw output in front of
> the patch.

Clarification.

Traditionally, we had diff-raw and diff-patch formats.
We can think of --name-status and --name-only variants of
diff-raw (just like different --abbrev settings give different
visuals for diff-raw).  Until very recently, these were either-or
output formats, but for Cogito we added an option to show both.

We could reorganize the output format options to:

	- diff-raw and its name variants
	- diff-stat
        - diff-patch

and have (internally) three bools to specify which ones to
output, in the above order.  The recent --patch-with-raw would
flip bit #0 (show raw) and bit #2 (show patch) on.  It is very
likely that diff-stat followed by diff-patch would be a popular
format (that is what git-format-patch does), and it also is
conceivable that diff-raw with diff-stat but without diff-patch
might turn out to be useful for some people.

Also, I forgot to mention, but would it be useful to have a
diffstat to show --cc?  It is unclear, without much thinking,
what the numbers would mean, though...

  reply	other threads:[~2006-04-13  6:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-13  1:02 [PATCH] diff-options: add --stat Johannes Schindelin
2006-04-13  1:15 ` Johannes Schindelin
2006-04-13  1:32   ` Johannes Schindelin
2006-04-13  4:54 ` Junio C Hamano
2006-04-13  6:53   ` Junio C Hamano [this message]
2006-04-13  8:29     ` Johannes Schindelin
2006-04-13 17:47     ` Marco Costalba
2006-04-13  6:59   ` Johannes Schindelin
2006-04-13 18:26 ` Junio C Hamano
2006-04-13 18:39   ` Linus Torvalds
2006-04-13 18:55     ` Junio C Hamano
2006-04-13 19:18       ` Linus Torvalds
2006-04-13 20:00   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vek02ynif.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox