From: Junio C Hamano <junkio@cox.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: "Lukas Sandström" <lukass@etek.chalmers.se>, git@vger.kernel.org
Subject: Re: [PATCH] speedup allocation in pack-redundant.c
Date: Tue, 22 Nov 2005 12:41:56 -0800 [thread overview]
Message-ID: <7vek58ct4b.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <81b0412b0511220656l528436b1xea80ee18965e4dda@mail.gmail.com> (Alex Riesen's message of "Tue, 22 Nov 2005 15:56:35 +0100")
Alex Riesen <raa.lkml@gmail.com> writes:
> Subject: [PATCH] speedup allocation in pack-redundant.c
>
> Reuse discarded nodes of llists
>
> Signed-off-by: Alex Riesen <ariesen@harmanbecker.com>
I think making allocation/deallocation to the central place is a
good cleanup, but I am not sure about the free-nodes reusing.
Does this make difference in real life? If so, it might be
worth doing the slab-like allocation, since free-nodes are very
small structure and malloc overhead is not ignorable there.
next prev parent reply other threads:[~2005-11-22 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-22 14:56 [PATCH] speedup allocation in pack-redundant.c Alex Riesen
2005-11-22 20:41 ` Junio C Hamano [this message]
2005-11-22 22:48 ` Lukas Sandström
2005-11-22 23:08 ` Junio C Hamano
2005-11-22 23:46 ` Alex Riesen
2005-11-22 23:00 ` Alex Riesen
2005-11-22 23:14 ` Lukas Sandström
2005-11-22 23:38 ` Alex Riesen
2005-11-22 23:55 ` Lukas Sandström
2005-11-23 7:31 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vek58ct4b.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=lukass@etek.chalmers.se \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).