From: Junio C Hamano <junkio@cox.net>
To: Andreas Ericsson <ae@op5.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/4] Server-side support for user-relative paths.
Date: Tue, 01 Nov 2005 16:14:44 -0800 [thread overview]
Message-ID: <7vek5z6h3f.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 20051101225921.3835C5BF73@nox.op5.se
Andreas Ericsson <ae@op5.se> writes:
> Remove the redundant code from {receive,upload}-pack.c in favour of the
> library code in path.c (previous patch) with documentation of the changes
> to the affected programs.
I like the simplification of these two calling sites, but it
makes me feel uneasy to see the workhorse named is_git_repo().
The name implies a check to see if the given path is a git repo
or not (i.e. side-effect free predicate), while what it actually
does are three things: (1) resolve and check, (2) chdir to it,
(3) set up GIT_DIR environment. Not that I have a better name
in mind...
> + SSH Is the default transport protocol and also supports an
Just a typo ("Is")?
next prev parent reply other threads:[~2005-11-02 0:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 22:59 [PATCH 3/4] Server-side support for user-relative paths Andreas Ericsson
2005-11-02 0:14 ` Junio C Hamano [this message]
2005-11-02 8:30 ` Andreas Ericsson
2005-11-02 9:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vek5z6h3f.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).