Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: torvalds@osdl.org
Cc: git@vger.kernel.org
Subject: Do you use "git-apply --show-files"?
Date: Sun, 16 Oct 2005 11:41:50 -0700	[thread overview]
Message-ID: <7vek6lxq1d.fsf@assigned-by-dhcp.cox.net> (raw)

As a part of "funny pathname character" updates, I was reviewing
"apply.c" and have two questions on its "--show-files" flag.

 * Unlike other informational flags like --stat and --summary,
   it does not turn off "apply".  Is it intentional? 

 * Do you (or anybody else) use it, and if so how?

The current code in the proposed updates branch decodes the same
C-style encoded pathnames GNU patch with proposed enhancements
would understand before applying patches, and when it needs to
show pathnames with --index-info, --stat, and --summary, it uses
the same encoded pathname to keep things on one line.

I think --show-files should also do the same for consistency,
but before I update it I wanted to ask the above questions.  If
nobody uses it, I can just ignore the issues and probably
remove the flag.

The plan is to backport the git-apply change to the maint branch
to do a 0.99.8e before updated git-diff-* hits the master
branch.  The only thing that would make a difference is embedded
SP.  Currently they are not quoted, but they will be, like this:

        : siamese; git diff
        diff --git "a/Read Me" "b/Read Me"
        index 3deac99..543a8f0 100644
        --- "a/Read Me"
        +++ "b/Read Me"
        ...

             reply	other threads:[~2005-10-16 18:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-16 18:41 Junio C Hamano [this message]
2005-10-17  0:45 ` Do you use "git-apply --show-files"? Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vek6lxq1d.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox