git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
	Matt McClure <matthewlmcclure@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: Avoiding broken Gitweb links and deleted objects
Date: Fri, 10 May 2013 09:22:15 -0700	[thread overview]
Message-ID: <7vfvxu3ivc.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vvc6r4855.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Fri, 10 May 2013 00:16:22 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Duy Nguyen <pclouds@gmail.com> writes:
>
>> On Fri, May 10, 2013 at 1:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Johannes Sixt <j.sixt@viscovery.net> writes:
>>> Imagine that a user runs "git rebase" on a history leading to commit
>>> X to create an alternate, improved history that leads to commit Y.
>>> What if we teach "git rebase" to record, perhaps by default, an
>>> "ours" merge on top of Y that takes the tree state of Y but has X as
>>> its second parent, and "git log" and its family to ignore such an
>>> artificial "ours" merge that records a tree that is identical to one
>>> of its parents, again perhaps by default?  "git log" works more or
>>> less in such a way already, but we might want to teach other modes
>>> like --full-history and --simplify-merges to ignore "ours" to hide
>>> such an artificial merge by default, with an audit option to
>>> unignore them.
>>
>> What about git-merge? Will it be fooled by these merges while looking
>> for merge bases?
>
> I thought it was obvious that we should ignore the side branches
> that were superseded this way, as by definition they did not
> contribute to the end result at all.
>
> But there must be something huge that I missed...

I think what I missed is that the same logic to ignore side branches
whose history gets cauterised with such an "ours" merge may apply to
an "ours" merge that people already make, but the latter may want to
take both histories into account.

So I guess it is not such a great idea.

  parent reply	other threads:[~2013-05-10 16:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08 16:16 Avoiding broken Gitweb links and deleted objects Matt McClure
2013-05-09 20:04 ` Matt McClure
2013-05-10  6:07 ` Johannes Sixt
2013-05-10  6:37   ` Junio C Hamano
2013-05-10  7:03     ` Johannes Sixt
2013-05-10  7:04     ` Duy Nguyen
2013-05-10  7:16       ` Junio C Hamano
2013-05-10 10:33         ` Duy Nguyen
2013-05-10 16:22         ` Junio C Hamano [this message]
2013-05-22 13:25           ` Matt McClure
2013-05-22 17:39             ` Junio C Hamano
2013-05-10  7:34     ` William Swanson
2013-05-22 13:32       ` Matt McClure
2013-05-22 15:41         ` William Swanson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfvxu3ivc.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=matthewlmcclure@gmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).