From: Junio C Hamano <gitster@pobox.com>
To: Nelson Elhage <nelhage@MIT.EDU>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-push: Accept -n as a synonym for --dry-run.
Date: Sat, 12 Sep 2009 19:44:29 -0700 [thread overview]
Message-ID: <7vfxar5zsi.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1252800302-26560-1-git-send-email-nelhage@mit.edu> (Nelson Elhage's message of "Sat\, 12 Sep 2009 20\:05\:02 -0400")
Nelson Elhage <nelhage@MIT.EDU> writes:
> '-n' is the standard way to specify a dry run for other git commands,
> so make 'git-push' accept it as well.
> ---
Sign-off?
Indeed -n is used in many places for --dry-run, but it is not _the_
standard way.
commit, push (as you identified), reflog, and send-email have --dry-run
but -n is not a synonym for it. Some of them even use -n as a shorthand
for a more often used option than --dry-run.
So the justification should be more like "push does not any other option
that deserves a short-and-sweet -n better, it will not have any such
option in the future, and --dry-run is very often used that it deserves to
use -n as its short-hand."
I tend to agree with the first two points, but I am not sure about the
third point. Do people dry-push that often?
next prev parent reply other threads:[~2009-09-13 2:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 0:05 [PATCH] git-push: Accept -n as a synonym for --dry-run Nelson Elhage
2009-09-13 2:44 ` Junio C Hamano [this message]
2009-09-13 3:40 ` Nelson Elhage
2009-09-13 3:54 ` Nelson Elhage
2009-09-13 5:23 ` Junio C Hamano
2009-09-13 6:10 ` Junio C Hamano
2009-09-13 17:07 ` Nelson Elhage
2009-09-13 5:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxar5zsi.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nelhage@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).