From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Mark A Rada <marada@uwaterloo.ca>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Aug 2009, #03; Thu, 20)
Date: Fri, 21 Aug 2009 13:10:10 -0700 [thread overview]
Message-ID: <7vfxbldj31.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <200908212006.16333.jnareb@gmail.com> (Jakub Narebski's message of "Fri\, 21 Aug 2009 20\:06\:12 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
>> +cat >>gitweb_config.perl <<EOF
>> +
>> +\$feature{'snapshot'}{'override'} = 0;
>> +EOF
>
> A trick: use '\EOF' and you don't need to escape $ against variable
> expansion by shell.
>
> +cat >>gitweb_config.perl <<\EOF
> +
> +$feature{'snapshot'}{'override'} = 0;
> +EOF
It is not a "trick" but is a basic courtesy for reviewers. Even if you do
not have any $ to worry about, _unless_ you actively know you would want
variable substitution to happen, it is easier for readers if you signal
the fact that the here-doc is verbatim by quoting the \EOF marker upfront.
Same thing for use of single quotes vs double quotes when writing strings,
even though they tend to be small and much less of an issue.
next prev parent reply other threads:[~2009-08-21 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 2:48 What's cooking in git.git (Aug 2009, #03; Thu, 20) Junio C Hamano
2009-08-21 9:10 ` Paolo Bonzini
2009-08-21 19:36 ` Junio C Hamano
2009-08-21 12:40 ` Mark A Rada
2009-08-21 18:06 ` Jakub Narebski
2009-08-21 20:10 ` Junio C Hamano [this message]
2009-08-22 22:42 ` [RFC] gitweb.perl t9500 t9501 Mark A Rada
2009-08-23 2:09 ` Junio C Hamano
2009-08-23 15:29 ` Mark A Rada
2009-08-21 21:43 ` What's cooking in git.git (Aug 2009, #03; Thu, 20) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxbldj31.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=marada@uwaterloo.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox