From: Junio C Hamano <gitster@pobox.com>
To: Geoffrey Irving <irving@naml.us>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] git fast-export: add --no-data option
Date: Sat, 25 Jul 2009 10:25:05 -0700 [thread overview]
Message-ID: <7vfxcku13i.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7f9d599f0907250645s6e6f9b81w3cf20f07eff088eb@mail.gmail.com> (Geoffrey Irving's message of "Sat\, 25 Jul 2009 09\:45\:19 -0400")
Geoffrey Irving <irving@naml.us> writes:
> @@ -504,6 +508,8 @@ int cmd_fast_export(int argc, const char **argv,
> const char *prefix)
> "Import marks from this file"),
> OPT_BOOLEAN(0, "fake-missing-tagger", &fake_missing_tagger,
> "Fake a tagger when tags lack one"),
> + OPT_BOOLEAN(0, "no-data", &no_data,
> + "Skip output of blob data"),
Shouldn't this be --[no-]data option that defaults to true? Otherwise you
would accept --no-no-data that looks silly.
> OPT_END()
> };
>
> --
> 1.6.3.1
next prev parent reply other threads:[~2009-07-25 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-25 13:45 [PATCH] git fast-export: add --no-data option Geoffrey Irving
2009-07-25 14:28 ` Johannes Schindelin
2009-07-25 17:25 ` Junio C Hamano [this message]
2009-07-25 17:44 ` Johannes Schindelin
2009-07-27 12:48 ` Geoffrey Irving
2009-07-27 18:49 ` Johannes Schindelin
2009-07-28 2:20 ` Geoffrey Irving
2009-07-28 4:11 ` Stephen Boyd
2009-07-28 8:01 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxcku13i.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=irving@naml.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox