From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Antony Stubbs <antony.stubbs@gmail.com>, git@vger.kernel.org
Subject: Re: cvs import and internal plumbing commands
Date: Tue, 21 Jul 2009 20:06:52 -0700 [thread overview]
Message-ID: <7vfxcpv2k3.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20090722025934.GB31254@coredump.intra.peff.net> (Jeff King's message of "Tue\, 21 Jul 2009 22\:59\:34 -0400")
Jeff King <peff@peff.net> writes:
> On Tue, Jul 21, 2009 at 05:43:08PM -0700, Junio C Hamano wrote:
>
>> Note that my suggestion on $PATH=$(git --exec-path):$PATH was a response
>> to Jeff's message, which was the same message your patch was response to.
>> In other words, our messages crossed, and I do not have an issue with
>> fixing this either way. If your patch fixes the issue correctly that
>> would be great.
>
> I am still confused about what the "issue" is. That is, why this is a
> bugfix for Anthony instead of simply a code modernization. IOW, I think
> there is something else broken about his install if cvsimport cannot
> find the dashed plumbing commands, and we may simply be papering over
> it.
I simply assumed that he was a correct install but for whatever crazy
reason is running /usr/local/libexec/git-core/git-cvsimport directly from
the command line. That usage won't be helped with the git wrapper at all.
I suspect shell scripted Porcelains like "git-pull" have the same issue,
as we do not seem to have "prepend to PATH" in git-sh-setup.sh at all.
Some like git-gui and instaweb do protect themselves, though.
> That being said, I think the code modernization is of value itself, so
> let's do it.
Agreed, and thanks.
prev parent reply other threads:[~2009-07-22 3:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 2:43 cvs import and internal plumbing commands Antony Stubbs
2009-07-05 6:28 ` Antony Stubbs
2009-07-06 12:15 ` [PATCH 1/1] " astubbs
2009-07-16 10:01 ` Jeff King
2009-07-17 21:44 ` Antony Stubbs
2009-07-17 21:45 ` Jeff King
2009-07-17 21:59 ` Antony Stubbs
2009-07-19 23:57 ` [PATCH] " Antony Stubbs
2009-07-20 2:43 ` Junio C Hamano
2009-07-20 15:34 ` Jeff King
2009-07-21 23:24 ` Antony Stubbs
2009-07-22 0:43 ` Junio C Hamano
2009-07-22 2:59 ` Jeff King
2009-07-22 3:06 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxcpv2k3.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=antony.stubbs@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).