git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Andy Lester <andy@petdance.com>, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Removed redundant static functions such as update_tracking_ref() and verify_remote_names() from builtin-send-pack.c, and made the ones in transport.c not be static so they can be used instead.
Date: Fri, 24 Apr 2009 15:41:54 -0700	[thread overview]
Message-ID: <7vfxfxad3h.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090424212313.GA14435@coredump.intra.peff.net> (Jeff King's message of "Fri, 24 Apr 2009 17:23:14 -0400")

Jeff King <peff@peff.net> writes:

> On Fri, Apr 24, 2009 at 04:13:14PM -0500, Andy Lester wrote:
>
>> This was what I was looking for.  I think what I'll do is fold your  
>> message into Documentation/SubmittingPatches and submit that as a patch 
>> first.
>
> That probably makes sense.
>
> I keep thinking about writing a separate "how to write a good commit
> message" document that would be more universal than just "here's how you
> submit a patch to git". And some of what I wrote to you could probably
> go in such a document. But I don't know if it makes sense to start a new
> document just with what I said there; it might be a bit sparse (OTOH,
> maybe people would then be encouraged to add their tips to it).

I'm sure our capable project secretary would come up with list of quotes
in the archive from Linus and I perhaps over the weekend in her copious
spare time ;-).

  reply	other threads:[~2009-04-24 22:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24  4:13 [PATCH] Removed redundant static functions such as update_tracking_ref() and verify_remote_names() from builtin-send-pack.c, and made the ones in transport.c not be static so they can be used instead andy
2009-04-24 21:04 ` Jeff King
2009-04-24 21:13   ` Andy Lester
2009-04-24 21:23     ` Jeff King
2009-04-24 22:41       ` Junio C Hamano [this message]
2009-04-25  0:07     ` Johannes Schindelin
2009-04-25  4:15       ` Andy Lester
2009-04-25  9:18         ` Johannes Schindelin
2009-04-27 14:38         ` Sam Vilain
2009-04-29  4:09           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfxfxad3h.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=andy@petdance.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).