From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] tests: remove xargs in favor of --stdin where possible
Date: Thu, 23 Apr 2009 01:36:58 -0700 [thread overview]
Message-ID: <7vfxfzwytx.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1240468281-23815-1-git-send-email-pclouds@gmail.com
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> Patch "Convert to use quiet option when available" reminds me I had a similar
> patch to remove (mostly) xargs usage from tests.
The reason being...?
(1) xargs is not universally available, or portable enough?
(2) people may learn from tests, and we should demostrate our ability?
(3) something else?
If the reason is (1) I would understand it, but if it is (2) then I am a
bit reluctant.
The tests may not break with your change because none of them may use
problematic characters (especially "\n" and '"'), but update-index --stdin
without -z is not suitable for reading from output from "find" without -0
option (on the other hand, "update-index -z --stdin" is good for reading
output from "find -0"; but for portability we avoid GNUism "find -0").
next prev parent reply other threads:[~2009-04-23 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 6:31 [PATCH] tests: remove xargs in favor of --stdin where possible Nguyễn Thái Ngọc Duy
2009-04-23 8:36 ` Junio C Hamano [this message]
2009-04-23 9:22 ` Johannes Sixt
2009-04-23 10:07 ` Nguyen Thai Ngoc Duy
2009-04-23 10:25 ` Junio C Hamano
2009-04-23 23:22 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxfzwytx.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).