From: Junio C Hamano <gitster@pobox.com>
To: Benjamin Kramer <benny.kra@googlemail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile: Use libc strlcpy on OSX
Date: Sat, 24 Jan 2009 10:39:05 -0800 [thread overview]
Message-ID: <7vfxj8o8fq.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7f978c810901240741k201f954dx1c0470186094ae24@mail.gmail.com> (Benjamin Kramer's message of "Sat, 24 Jan 2009 16:41:30 +0100")
Benjamin Kramer <benny.kra@googlemail.com> writes:
> OSX supports strlcpy(3) since 10.2 so we don't need
> to use our own.
How does your patch to Makefile refrain from kicking in for people with
OSX older than 10.2, so that their builds are not broken?
>
> Signed-off-by: Benjamin Kramer <benny.kra@gmail.com>
> ---
> Makefile | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b4d9cb4..4c9aab5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -643,7 +643,6 @@ ifeq ($(uname_S),Darwin)
> ifneq ($(shell expr "$(uname_R)" : '9\.'),2)
> OLD_ICONV = UnfortunatelyYes
> endif
> - NO_STRLCPY = YesPlease
> NO_MEMMEM = YesPlease
> THREADED_DELTA_SEARCH = YesPlease
> endif
next prev parent reply other threads:[~2009-01-24 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 15:41 [PATCH] Makefile: Use libc strlcpy on OSX Benjamin Kramer
2009-01-24 18:39 ` Junio C Hamano [this message]
2009-01-24 18:51 ` Benjamin Kramer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxj8o8fq.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=benny.kra@googlemail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).