From: Junio C Hamano <gitster@pobox.com>
To: Anders Melchiorsen <mail@cup.kalibalik.dk>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [RFC PATCH] Make the rebase edit mode really end up in an edit state
Date: Wed, 14 Jan 2009 16:43:14 -0800 [thread overview]
Message-ID: <7vfxjlxuu5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <87ab9th0rh.fsf@cup.kalibalik.dk> (Anders Melchiorsen's message of "Thu, 15 Jan 2009 01:27:14 +0100")
Anders Melchiorsen <mail@cup.kalibalik.dk> writes:
> I always have a hard time figuring out what to do during an
> interactive rebase. Recently, it dawned on me that the reason is that
> I have to do different things: one thing when editing on purpose, and
> a different thing when resolving a conflict. So my fingers never learn.
>
> With this change, I propose to make the UI more uniform. I think that
> the new way is more intuitive, too, if you will agree that a Git UI
> can be intuitive.
>
> As I expect this to not be acceptable due to compatibility concerns, I
> have not tested it much. The patch is mostly to catch some attention,
> but I will be happy to complete it if there is interest in the change.
>
> It was surprising for me to find the needed code already present. Now
> I know that I do not have to do "git commit --amend", it will happen
> automatically if I add some files. That trick alone is worth the time
> that I have spent on this :-).
We may need a version bump to 1.7.0 to update the UI for this command, but
please do test rigorously to build a stronger case for a saner UI.
I've always had trouble with the instruction we give for splitting one
commit into two using the interactive rebase in the documentation, as it
always had a strong "Huh?" effect on me when it suddenly starts talking
about doing a "git reset HEAD^"; I suspect your change may improve this
situation quite a bit.
next prev parent reply other threads:[~2009-01-15 0:44 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 0:27 [RFC PATCH] Make the rebase edit mode really end up in an edit state Anders Melchiorsen
2009-01-15 0:43 ` Junio C Hamano [this message]
2009-01-15 2:49 ` Boyd Stephen Smith Jr.
2009-01-15 4:10 ` Miles Bader
2009-01-15 5:00 ` Boyd Stephen Smith Jr.
2009-01-15 6:13 ` Junio C Hamano
2009-01-15 12:24 ` Johannes Schindelin
2009-01-15 15:35 ` SZEDER Gábor
2009-01-15 22:09 ` Junio C Hamano
2009-01-15 22:20 ` Sverre Rabbelier
2009-01-15 22:59 ` SZEDER Gábor
2009-01-16 0:11 ` Björn Steinbrink
2009-01-16 1:34 ` Johannes Schindelin
2009-01-18 1:24 ` Anders Melchiorsen
2009-01-16 1:09 ` Junio C Hamano
2009-01-16 12:10 ` Johannes Schindelin
2009-01-15 0:49 ` Stephan Beyer
2009-01-15 0:53 ` Johannes Schindelin
2009-01-15 7:35 ` Johannes Sixt
2009-01-15 10:01 ` Johan Herland
2009-01-15 11:52 ` Sverre Rabbelier
2009-01-15 12:36 ` Johannes Schindelin
2009-01-15 12:44 ` Adeodato Simó
2009-01-15 13:41 ` Johannes Schindelin
2009-01-15 13:41 ` Sverre Rabbelier
2009-01-15 13:57 ` Stephan Beyer
2009-01-15 14:02 ` Johannes Schindelin
2009-01-15 13:43 ` Adeodato Simó
2009-01-15 12:45 ` Sverre Rabbelier
2009-01-15 13:42 ` Johannes Schindelin
2009-01-15 13:56 ` Sverre Rabbelier
2009-01-15 16:59 ` Junio C Hamano
2009-01-15 17:16 ` Sverre Rabbelier
2009-01-15 18:21 ` Johannes Schindelin
2009-01-15 18:46 ` Johan Herland
2009-01-15 18:53 ` Anders Melchiorsen
2009-01-15 19:28 ` Johannes Schindelin
2009-01-15 19:27 ` Wincent Colaiuta
2009-01-15 20:26 ` Jay Soffian
2009-01-15 21:58 ` Wincent Colaiuta
2009-01-16 9:50 ` Johan Herland
2009-01-16 10:27 ` Anders Melchiorsen
2009-01-16 10:58 ` Johan Herland
2009-01-16 12:42 ` SZEDER Gábor
2009-01-16 12:57 ` Johannes Schindelin
2009-01-16 13:27 ` SZEDER Gábor
2009-01-16 14:28 ` Wincent Colaiuta
2009-01-16 13:12 ` Sverre Rabbelier
2009-01-16 17:26 ` Stephan Beyer
2009-01-16 21:06 ` Johannes Schindelin
2009-01-15 12:52 ` Pieter de Bie
2009-01-15 12:55 ` Sverre Rabbelier
2009-01-15 12:57 ` Pieter de Bie
2009-01-15 13:46 ` Björn Steinbrink
2009-01-15 13:54 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxjlxuu5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mail@cup.kalibalik.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).