From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH] diff --no-index: test for pager after option parsing
Date: Tue, 06 Jan 2009 16:09:18 -0800 [thread overview]
Message-ID: <7vfxjwf041.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1231286163-9422-1-git-send-email-trast@student.ethz.ch> (Thomas Rast's message of "Wed, 7 Jan 2009 00:56:03 +0100")
Thomas Rast <trast@student.ethz.ch> writes:
> I noticed this while working on the earlier patch for diff --no-index.
> It seems like the right thing to do (and passes tests), but I don't
> have a clue about git's normal setup sequences, so I'm flagging it
> RFC.
I think the patch itself makes sense from the logic flow point of view.
But I wonder if it still makes a difference in real life.idn't we stop
reporting the exit status from the pager some time ago?
next prev parent reply other threads:[~2009-01-07 0:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 23:56 [RFC PATCH] diff --no-index: test for pager after option parsing Thomas Rast
2009-01-07 0:09 ` Thomas Rast
2009-01-07 0:09 ` Junio C Hamano [this message]
2009-01-07 3:20 ` Miklos Vajna
2009-01-07 6:42 ` Jeff King
2009-01-07 7:02 ` Junio C Hamano
2009-01-07 11:15 ` [PATCH] diff --no-index -q: fix endless loop Thomas Rast
2009-01-07 21:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxjwf041.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).