From: Junio C Hamano <gitster@pobox.com>
To: Abhijit Menon-Sen <ams@toroid.org>
Cc: Eric Wong <normalperson@yhbt.net>,
Nanako Shiraishi <nanako3@lavabit.com>,
git@vger.kernel.org
Subject: Re: [PATCH] t/t91XX-svn: start removing use of "git-" from these tests
Date: Tue, 09 Sep 2008 01:40:23 -0700 [thread overview]
Message-ID: <7vfxo9af0o.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080909022343.GB19190@toroid.org> (Abhijit Menon-Sen's message of "Tue, 9 Sep 2008 07:53:43 +0530")
Abhijit Menon-Sen <ams@toroid.org> writes:
> At 2008-09-08 03:27:59 -0700, normalperson@yhbt.net wrote:
>>
>> They'll show up as false positives when grepping for "git-"
>
> Fine, you're the maintainer, but for the record, I think this change is
> dreadful. Changing all "git-svn blah" commands to "git svn blah" is one
> thing, but obfuscating tests on the off-chance that someone might grep
> for "git-" seems entirely wrong.
I think the value of this first one is not "on the off-chance" thing, but
the presense of this change makes it far easier to eyeball the result of
applying the second, large-ish patch.
If I were doing this as a series, I would probably have followed them up
with a patch that reverts the token replacement this first one does as the
final patch in the series, but I also think leaving this first patch as-is
is fine.
prev parent reply other threads:[~2008-09-09 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 10:02 [PATCH] t/t91XX-svn: start removing use of "git-" from these tests Nanako Shiraishi
2008-09-08 10:16 ` Abhijit Menon-Sen
2008-09-08 10:27 ` Eric Wong
2008-09-09 2:23 ` Abhijit Menon-Sen
2008-09-09 8:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxo9af0o.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=ams@toroid.org \
--cc=git@vger.kernel.org \
--cc=nanako3@lavabit.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).