From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@uchicago.edu>
Cc: git@vger.kernel.org, David Greaves <david@dgreaves.com>
Subject: Re: [PATCH] bring description of git diff --cc up to date
Date: Mon, 21 Jul 2008 23:41:39 -0700 [thread overview]
Message-ID: <7vfxq2pgik.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.GSO.4.62.0807211316530.2841@harper.uchicago.edu> (Jonathan Nieder's message of "Mon, 21 Jul 2008 13:27:23 -0500 (CDT)")
Jonathan Nieder <jrnieder@uchicago.edu> writes:
> + This flag implies the '-c' option and makes the patch output
> + even more compact by omitting uninteresting hunks. A hunk is
> + considered interesting only if either (a) it shows changes from
> + all parents or (b) in an Octopus merge, it shows different changes
> + from at least three different parents.
I am not sure where that "at lesta three different parents" comes from.
It might be that what the logic does can be expressed that way, but that
was not the guiding principle why the code does what it currently does.
These two might make it clearer what hunks are considered interesting:
http://thread.gmane.org/gmane.comp.version-control.git/15098/focus=15109
http://thread.gmane.org/gmane.comp.version-control.git/15486/focus=15491
Especially the latter thread, not just the focused one but the whole
thing, is quite amusing.
This one gives an insight into the logical consequence of the hunk
selection criteria:
http://thread.gmane.org/gmane.comp.version-control.git/15486/focus=15600
it is worth a read after understanding why some hunks are omitted and some
hunks are included by reading other articles in the thread.
next prev parent reply other threads:[~2008-07-22 6:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 18:27 [PATCH] bring description of git diff --cc up to date Jonathan Nieder
2008-07-22 6:41 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-07-22 16:19 Jonathan Nieder
2008-07-22 17:09 ` Junio C Hamano
2008-07-22 21:21 ` Junio C Hamano
2008-07-22 23:27 ` Jonathan Nieder
2008-07-23 0:36 ` Junio C Hamano
2008-07-23 3:55 ` Jonathan Nieder
2008-07-23 23:15 ` Junio C Hamano
2008-07-24 0:35 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxq2pgik.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=david@dgreaves.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@uchicago.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).