From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Pierre Habouzit <madcoder@debian.org>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] revisions: refactor handle_revision_opt into parse_revision_opt.
Date: Thu, 10 Jul 2008 00:36:34 -0700 [thread overview]
Message-ID: <7vfxqiqjgd.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080710071418.GD3195@sigill.intra.peff.net> (Jeff King's message of "Thu, 10 Jul 2008 03:14:18 -0400")
Jeff King <peff@peff.net> writes:
> but it also seems like the top bit of that for loop is boilerplate, too:
>
>> for (;;) {
>> switch (parse_options_step(&ctx, options, shortlog_usage)) {
>> case PARSE_OPT_HELP:
>> exit(129);
>> case PARSE_OPT_DONE:
>> goto parse_done;
>> }
Another thing we should be able to refactor is the option help formatter.
Cf. 071438a (Teach git-merge -X<option> again., 2008-07-09)
prev parent reply other threads:[~2008-07-10 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 21:38 [PATCH] git-shortlog: migrate to parse-options partially Pierre Habouzit
2008-07-09 21:38 ` [PATCH] revisions: refactor handle_revision_opt into parse_revision_opt Pierre Habouzit
2008-07-10 7:14 ` Jeff King
2008-07-10 7:34 ` Pierre Habouzit
2008-07-10 7:40 ` Pierre Habouzit
2008-07-10 7:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxqiqjgd.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).