From: Junio C Hamano <gitster@pobox.com>
To: Adam Simpkins <adam@adamsimpkins.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix output of "git log --graph --boundary"
Date: Sun, 25 May 2008 12:20:58 -0700 [thread overview]
Message-ID: <7vfxs6i411.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1211670125-10215-2-git-send-email-adam@adamsimpkins.net> (Adam Simpkins's message of "Sat, 24 May 2008 16:02:04 -0700")
Adam Simpkins <adam@adamsimpkins.net> writes:
> diff --git a/revision.c b/revision.c
> index 1341f3d..181fb0b 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -1697,7 +1697,7 @@ static struct commit *get_revision_internal(struct rev_info *revs)
> * switch to boundary commits output mode.
> */
> revs->boundary = 2;
> - return get_revision(revs);
> + return get_revision_internal(revs);
> }
>
> /*
This hunk first got me worried, but this is a simple bugfix to 7fefda5
(log and rev-list: add --graph option, 2008-05-04) and does not break
callers without --graph option.
Looks good, thanks.
prev parent reply other threads:[~2008-05-25 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-24 23:02 [PATCH 0/2] Fix output of "git log --graph --boundary" Adam Simpkins
2008-05-24 23:02 ` [PATCH 1/2] " Adam Simpkins
2008-05-24 23:02 ` [PATCH 2/2] get_revision(): honor the topo_order flag for boundary commits Adam Simpkins
2008-05-25 19:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxs6i411.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=adam@adamsimpkins.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).