From: Junio C Hamano <gitster@pobox.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-commit: exit non-zero if we fail to commit the index
Date: Tue, 22 Jan 2008 15:42:27 -0800 [thread overview]
Message-ID: <7vfxwpqvfg.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <47964370.8010300@nrlssc.navy.mil> (Brandon Casey's message of "Tue, 22 Jan 2008 13:26:40 -0600")
Brandon Casey <casey@nrlssc.navy.mil> writes:
> ---
>
>
> Junio C Hamano wrote:
>> Brandon Casey <casey@nrlssc.navy.mil> writes:
>>
>>>> We would need to tell the user that the index is not where
>>>> it is when we detect the error, though.
>>> The new index we are trying to rename will be deleted.
>>> Are you saying we should
>>> warn the user that the index is now out of sync?
>>
>> Yeah, something like that. But I think that once this happens
>> there is no easy and sane recovery path for the user, as the
>> most likely cause of the failure there would be the user running
>> out of quota, so "git reset HEAD" which may be the way to
>> recover from that failure would not have enough room to create a
>> new index file anyway.
>
> If you're interested, here's a patch.
Looks Ok from a quick glance. I am mired at day job this week
so it may take a while for me to come up with a commit log
message though.
next prev parent reply other threads:[~2008-01-22 23:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 0:07 [PATCH] git-commit: exit non-zero if we fail to commit the index Brandon Casey
2008-01-17 1:13 ` Junio C Hamano
2008-01-17 1:49 ` Brandon Casey
2008-01-17 2:11 ` Junio C Hamano
2008-01-22 19:26 ` Brandon Casey
2008-01-22 23:42 ` Junio C Hamano [this message]
2008-01-23 17:21 ` Brandon Casey
2008-01-23 20:01 ` Junio C Hamano
2008-01-23 20:47 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxwpqvfg.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).