git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
	Jakub Narebski <jnareb@gmail.com>,
	Alex Riesen <raa.lkml@gmail.com>, Andreas Ericsson <ae@op5.se>,
	Matthieu Moy <Matthieu.Moy@imag.fr>,
	Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 2/3] git-help: add -w|--web option to display html man page in a browser.
Date: Thu, 06 Dec 2007 23:05:01 -0800	[thread overview]
Message-ID: <7vfxyf7zoi.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7v1w9z9h2k.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Thu, 06 Dec 2007 22:04:03 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> Christian Couder <chriscool@tuxfamily.org> writes:
> ...
>>> > +init_browser_path() {
>>> > +	browser_path=`git config browser.$1.path`
>>> > +	test -z "$browser_path" && browser_path=$1
>>> > +}
>>>
>>> Please do not contaminate the config file with something the user can
>>> easily use a lot more standardized way (iow $PATH) to configure to his
>>> taste.
>>>
>>> I'd suggest dropping this bit.

Well, I changed my mind.  It is a bit funny to have both firefox and
iceweasel as "valid-tool", but if we consider $browser to define the
external interface and $browser_path to define the implementation, it
sort of makes sense to have that configuration.  browser_path could be
iceweasel for browser firefox.

I'll squash the patch to update the one from the last round (as the last
two patches are not yet accepted in 'next' yet), remove the html
documentation path fallback, but will leave this part in.

browser.*.path and web.browser configuration need to be documented, if
not already, though.

  reply	other threads:[~2007-12-07  7:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-02  5:07 [PATCH 2/3] git-help: add -w|--web option to display html man page in a browser Christian Couder
2007-12-06 17:03 ` Junio C Hamano
2007-12-07  5:35   ` Christian Couder
2007-12-07  6:04     ` Junio C Hamano
2007-12-07  7:05       ` Junio C Hamano [this message]
2007-12-08  4:00         ` Christian Couder
2007-12-06 17:05 ` Junio C Hamano
2007-12-08  8:28 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfxyf7zoi.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@imag.fr \
    --cc=ae@op5.se \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=normalperson@yhbt.net \
    --cc=raa.lkml@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).