From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] rev-list --bisect: Bisection "distance" clean up.
Date: Sun, 16 Sep 2007 01:54:06 -0700 [thread overview]
Message-ID: <7vfy1f56tt.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20070915130016.eac885f4.chriscool@tuxfamily.org> (Christian Couder's message of "Sat, 15 Sep 2007 13:00:16 +0200")
Christian Couder <chriscool@tuxfamily.org> writes:
> diff --git a/builtin-rev-list.c b/builtin-rev-list.c
> index c2ce1fc..6ade3b7 100644
> --- a/builtin-rev-list.c
> +++ b/builtin-rev-list.c
> @@ -189,7 +189,7 @@ static int count_interesting_parents(struct commit *commit)
> return count;
> }
>
> -static inline int halfway(struct commit_list *p, int distance, int nr)
> +static inline int halfway(struct commit_list *p, int nr)
> {
This makes sense as we always call with "distance = weight(p)".
But is this three-patch series really needed? We see this kind
of clean-ups often as a prelude to a larger set of enhancements,
building up anticipation for smarter and more beautiful things
to come, and seeing the series end here leaves me wondering
"Huh? Is that it?".
Not that clean-up itself does not have any value, but still...
next prev parent reply other threads:[~2007-09-16 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-15 11:00 [PATCH 3/3] rev-list --bisect: Bisection "distance" clean up Christian Couder
2007-09-15 11:15 ` Johannes Schindelin
2007-09-15 11:47 ` Christian Couder
2007-09-16 8:54 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-09-17 3:28 Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfy1f56tt.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).