From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Git Mailing List <git@vger.kernel.org>, Alex Riesen <raa.lkml@gmail.com>
Subject: Re: [PATCH 8/6] Teach directory traversal about subprojects
Date: Wed, 11 Apr 2007 17:50:58 -0700 [thread overview]
Message-ID: <7vfy76mn4d.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0704111439210.6730@woody.linux-foundation.org> (Linus Torvalds's message of "Wed, 11 Apr 2007 14:49:44 -0700 (PDT)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> Yes, this adds many more lines than it removes, but 40 of the added lines
> really are just added comments about what we're doing. And the end result
> really is more readable too even if ignoring the comments, I think.
Much nicer to read.
> diff --git a/dir.h b/dir.h
> index 33c31f2..1931609 100644
> --- a/dir.h
> +++ b/dir.h
> @@ -33,7 +33,8 @@ struct dir_struct {
> int nr, alloc;
> unsigned int show_ignored:1,
> show_other_directories:1,
> - hide_empty_directories:1;
> + hide_empty_directories:1,
> + no_dirlinks;
> struct dir_entry **entries;
>
> /* Exclude info */
Did you mean a bitfield here?
next prev parent reply other threads:[~2007-04-12 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 21:49 [PATCH 8/6] Teach directory traversal about subprojects Linus Torvalds
2007-04-12 0:50 ` Junio C Hamano [this message]
2007-04-12 1:53 ` Linus Torvalds
2007-04-12 2:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfy76mn4d.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).