Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Petr Baudis <pasky@suse.cz>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH] [RFC] Introduce Git.pm
Date: Thu, 22 Jun 2006 02:01:46 -0700	[thread overview]
Message-ID: <7vfyhxtvgl.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060622003546.17760.23089.stgit@machine.or.cz> (Petr Baudis's message of "Thu, 22 Jun 2006 02:35:46 +0200")

Petr Baudis <pasky@suse.cz> writes:

> This patch introduces a very basic and barebone Git.pm module
> with a sketch of how the generic interface would look like;

In addition to my previous comments...

> +  my $version = Git::generic_oneval('version');
> +  my $lastrev = $repo->generic_oneval('rev-list', '--all');
> +...
> +=item generic_oneline ( COMMAND [, ARGUMENTS... ] )
> +...
> +sub generic_oneline {
> +	my $fh = generic(@_);
> +	my $line = <$fh>;
> +	close $fh;
> +	chomp $line;
> +	return $line;
> +}

Let's have a cleaned up version of Git.pm, Makefile changes and
changes to git-fmt-merge-msg.perl that shows how to use the
module.  Being in-tree would help people to view, use and
comment on it.

      parent reply	other threads:[~2006-06-22  9:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-22  0:35 [PATCH] [RFC] Introduce Git.pm Petr Baudis
2006-06-22  1:03 ` Junio C Hamano
2006-06-22  7:18   ` Alex Riesen
2006-06-22 19:37   ` Petr Baudis
2006-06-22  2:31 ` Eric Wong
2006-06-22  8:07 ` Jakub Narebski
2006-06-22  9:01 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfyhxtvgl.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox