From: Junio C Hamano <junkio@cox.net>
To: ltuikov@yahoo.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH rev-list.c] max-count in terms of intersection
Date: Fri, 18 Nov 2005 15:42:12 -0800 [thread overview]
Message-ID: <7vfyptfrqj.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20051118224233.50766.qmail@web31805.mail.mud.yahoo.com> (Luben Tuikov's message of "Fri, 18 Nov 2005 14:42:33 -0800 (PST)")
Luben Tuikov <ltuikov@yahoo.com> writes:
>> This makes sense, but I wonder if the same logic applies to
>> max_age as well. If we have clock-skewed commits that are
>> skipped by the DENSE processing, we probably do not want them to
>> be affecting what to do on the commits that matter.
>
> As far as I understand it, I think max-age is fine the way
> it is. After all, max-age depends on date/time which is
> absolute (i.e. applies to commits in the whole set and in
> the intersection just the same).
It is recorded absolutely but what if committer's clock is
broken on one commit but not others, and if you are not using
the default sort_by_date() (e.g. --topo-order)?
prev parent reply other threads:[~2005-11-18 23:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 21:47 [PATCH rev-list.c] max-count in terms of intersection Luben Tuikov
2005-11-18 22:18 ` Junio C Hamano
2005-11-18 22:42 ` Luben Tuikov
2005-11-18 23:42 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfyptfrqj.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox