git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Teach applymbox to keep the Subject: line.
Date: Wed, 17 Aug 2005 13:42:57 -0700	[thread overview]
Message-ID: <7vfyt8thv2.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: Pine.LNX.4.58.0508171253190.3553@g5.osdl.org

Linus Torvalds <torvalds@osdl.org> writes:

> The fact is, anybody who doesn't edit the emails that come in is BROKEN. 
> There are two kinds of emails:
>
>  - the nicely formatted ones where the author follows all the rules
>
>    This kind of email doesn't need MIME decoding anyway.

That depends on what the rules are, but I consider detecting B
encodings in the header fields and transliterating it into UTF-8
a good idea (although that sometimes is a lossy conversion
depending on the original charset).

Remember this one that prompted me to do the header folding?

    From: YOSHIFUJI Hideaki / =?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= 
            <yoshfuji@linux-ipv6.org>

>  - the others

>    ..., trying to handle it 
>    automatically is WRONG WRONG WRONG.
>    And if it's mime-encoded you often have trouble editing it anyway.
>
> Ergo: if somebody sends you mime-encoded patches, hit them with a baseball 
> bat (politely) and teach them not to do that. "Fixing" the tools really 
> will just make things worse if it means that you apply raw emails without 
> having edited them.

I agree with you in principle and that is why I always run
applymbox with the -q flag.  Maybe I should start trying the
baseball bat approach to see what happens.

  reply	other threads:[~2005-08-17 20:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-16 21:47 [RFC] Patches exchange is bad? Marco Costalba
2005-08-16 22:31 ` [PATCH] git-format-patch fix Junio C Hamano
2005-08-17  5:47   ` [PATCH] Teach applymbox to keep the Subject: line Junio C Hamano
2005-08-17 15:38     ` Linus Torvalds
2005-08-18 17:26       ` Sam Ravnborg
2005-08-18 20:07         ` Linus Torvalds
2005-08-19  1:04           ` Junio C Hamano
2005-08-19 21:41           ` [PATCH] Add hooks to tools/git-applypatch Junio C Hamano
2005-08-19  1:04         ` [PATCH] Teach applymbox to keep the Subject: line Junio C Hamano
2005-08-17 17:36     ` Jeff Garzik
2005-08-17 19:26       ` Junio C Hamano
2005-08-17 19:56       ` Linus Torvalds
2005-08-17 20:42         ` Junio C Hamano [this message]
2005-08-17 21:36         ` Johannes Schindelin
2005-08-18 10:32         ` David Kågedal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfyt8thv2.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=jgarzik@pobox.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).