From: Junio C Hamano <gitster@pobox.com>
To: Albert Netymk <albertnetymk@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git-diff-index man page
Date: Sun, 19 May 2013 00:46:00 -0700 [thread overview]
Message-ID: <7vhahzza2v.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAKEGsXQDB1=hizNqM6D=uuP6PXT4ytUiTgB5fvO-gVSsPqQkLQ@mail.gmail.com> (Albert Netymk's message of "Sat, 18 May 2013 18:26:11 +0200")
Albert Netymk <albertnetymk@gmail.com> writes:
> Hello,
>
> The man page of git-diff-index:
> http://git-scm.com/docs/git-diff-index
> states that
> `git-diff-index - Compares content and mode of blobs between the index
> and repository`.
>
> However, in fact this command compares between files on disk and
> repository by default. It's explained clearly in here:
> http://git-scm.com/docs/gitdiffcore
>
> Maybe the man page could be updated to reflect this in NAME section:
> `git-diff-index - Compares content and mode of blobs between files on
> disk and repository or between the index and repository`
Surely; we need to keep it fit on a single line, though.
> In DESCRIPTION section:
> `Compares the content and mode of the blobs found via a tree object
> with the content of the files on disk by default, and could be
> compared with index only using cached option. ...`
Yes, mentioning both mode is a good change. The above exact text
may give a false impression (with that "by default") that it is
somehow more preferrable to compare tree with working tree through
the index, and only weirdos would use "--cached" to compare tree and
the index, though.
Patches welcome. Thanks.
next prev parent reply other threads:[~2013-05-19 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 16:26 git-diff-index man page Albert Netymk
2013-05-19 7:46 ` Junio C Hamano [this message]
2013-05-19 20:23 ` Albert Netymk
2013-05-20 5:01 ` Junio C Hamano
2013-05-20 5:40 ` Eric Sunshine
2013-05-20 6:27 ` Jonathan Nieder
2013-05-20 22:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhahzza2v.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=albertnetymk@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).