fetch --no-tags with and w/o --all

fetch --no-tags with and w/o --all

[Cristian Tibirna]

Hello

$ git --version
git version 1.7.10.4

$ git fetch origin --no-tags
does what it says

$ git fetch --all --no-tags
still gets all the tags from the remote.

Is this known?

Thanks.

-- 
Cristian Tibirna				(1-418-) 656-2131 / 4340
  Laval University - Quebec, CAN ... http://www.giref.ulaval.ca/~ctibirna
  Research professional at GIREF ... ctibirna@giref.ulaval.ca

Re: fetch --no-tags with and w/o --all

[Junio C Hamano]

Cristian Tibirna <ctibirna@giref.ulaval.ca> writes:

> Hello
>
> $ git --version
> git version 1.7.10.4
>
> $ git fetch origin --no-tags
> does what it says
>
> $ git fetch --all --no-tags
> still gets all the tags from the remote.
>
> Is this known?

Because --all (or --multiple) to iterate through all remotes
does not pass accept any command line refspecs, using these options
with --no-tags and/or --tags should be diagnosed as an error, but it
appears that the error checking is not done.

Re: fetch --no-tags with and w/o --all

[Jeff King]

On Wed, Mar 06, 2013 at 01:56:01PM -0800, Junio C Hamano wrote:

> Cristian Tibirna <ctibirna@giref.ulaval.ca> writes:
> 
> > Hello
> >
> > $ git --version
> > git version 1.7.10.4
> >
> > $ git fetch origin --no-tags
> > does what it says
> >
> > $ git fetch --all --no-tags
> > still gets all the tags from the remote.
> >
> > Is this known?
> 
> Because --all (or --multiple) to iterate through all remotes
> does not pass accept any command line refspecs, using these options
> with --no-tags and/or --tags should be diagnosed as an error, but it
> appears that the error checking is not done.

Or we could just pass them through. Looks like this was already fixed by
8556646 (fetch --all: pass --tags/--no-tags through to each remote,
2012-09-05), which is in v1.7.12.2 and higher.

-Peff

Re: fetch --no-tags with and w/o --all

[Junio C Hamano]

Jeff King <peff@peff.net> writes:

> On Wed, Mar 06, 2013 at 01:56:01PM -0800, Junio C Hamano wrote:
>
>> Cristian Tibirna <ctibirna@giref.ulaval.ca> writes:
>> 
>> > Hello
>> >
>> > $ git --version
>> > git version 1.7.10.4
>> >
>> > $ git fetch origin --no-tags
>> > does what it says
>> >
>> > $ git fetch --all --no-tags
>> > still gets all the tags from the remote.
>> >
>> > Is this known?
>> 
>> Because --all (or --multiple) to iterate through all remotes
>> does not pass accept any command line refspecs, using these options
>> with --no-tags and/or --tags should be diagnosed as an error, but it
>> appears that the error checking is not done.
>
> Or we could just pass them through. Looks like this was already fixed by
> 8556646 (fetch --all: pass --tags/--no-tags through to each remote,
> 2012-09-05), which is in v1.7.12.2 and higher.

;-)  No wonder this looked somewhat familiar.

Re: fetch --no-tags with and w/o --all

[Jeff King]

On Wed, Mar 06, 2013 at 04:41:44PM -0800, Junio C Hamano wrote:

> > Or we could just pass them through. Looks like this was already fixed by
> > 8556646 (fetch --all: pass --tags/--no-tags through to each remote,
> > 2012-09-05), which is in v1.7.12.2 and higher.
> 
> ;-)  No wonder this looked somewhat familiar.

I still find it somewhat gross that we actually re-construct the
command-line from the parsed flag variables. It seems like it would be
easier to simply propagate the argv we got in the first place, and then
we would not have any chance of omitting a new option that is added
later.

Probably not worth worrying about now, though, as the fix is long since
shipped.  The next person who is adding an option can look at doing that
refactoring. And it may be that there are some options we don't
propagate intentionally (I didn't look closely).

-Peff