git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Jean-Noël AVILA" <jn.avila@free.fr>, git@vger.kernel.org
Subject: Re: [RFC] Instruct git-completion.bash that we are in test mode
Date: Mon, 21 Jan 2013 20:31:45 -0800	[thread overview]
Message-ID: <7vham9dej2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130122003954.GA23297@sigill.intra.peff.net> (Jeff King's message of "Mon, 21 Jan 2013 19:39:55 -0500")

Jeff King <peff@peff.net> writes:

> I really hate to suggest this, but should it be more like:
>
>   if test -z "$FAKE_COMMAND_LIST"; then
>           __git_cmdlist() {
>                   git help -a | egrep '^  [a-zA-Z0-9]'
>           }
>   else
>           __git_cmdlist() {
>                   printf '%s' "$FAKE_COMMAND_LIST"
>           }
>   fi
>
> That gives us a nice predictable starting point for actually testing the
> completion code. The downside is that it  doesn't let us test that we
> remain compatible with the output of "help -a".

Yeah, I think this is simpler and more to the point for the test in
t9902.  If we really want to test something that is the same as, or
at least any closer than this approach (or my "help --standard"), to
what the real users use, the test has to become inherently flaky, so
I think we should go for the simplicity of this patch shows.

  reply	other threads:[~2013-01-22  4:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 22:30 [RFC] Instruct git-completion.bash that we are in test mode Jean-Noël AVILA
2013-01-21 23:32 ` Junio C Hamano
2013-01-22  0:39   ` Jeff King
2013-01-22  4:31     ` Junio C Hamano [this message]
2013-01-22  8:04       ` Jean-Noël Avila
2013-01-22 16:31         ` Junio C Hamano
2013-01-24 23:07     ` [PATCH] t9902: protect test from stray build artifacts Junio C Hamano
2013-01-25  1:13       ` Jeff King
2013-01-25  2:59         ` Jonathan Nieder
2013-01-25  4:11         ` Junio C Hamano
2013-01-25  4:13           ` Jeff King
2013-01-25  4:19           ` Junio C Hamano
2013-01-25  4:23             ` Jeff King
2013-01-25 18:34               ` Junio C Hamano
2013-01-25 22:06                 ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vham9dej2.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jn.avila@free.fr \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).