From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] completion: add format-patch options to send-email
Date: Mon, 15 Oct 2012 16:28:23 -0700 [thread overview]
Message-ID: <7vhapvuxgo.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20121015224857.GA2156@goldbirke> ("SZEDER Gábor"'s message of "Tue, 16 Oct 2012 00:48:57 +0200")
SZEDER Gábor <szeder@ira.uka.de> writes:
>> + cd test
>
> This 'cd' makes all subsequent tests to be executed in a different
> repository than previously, which breaks 'checkout completes ref
> names'.
Yeah, thanks for spotting and yelling at it ;-).
We really need to be careful about tests that cd around. Even the
ones that only go down and expect the rest of the test to run in
that subdirectory may later have to be modified by somebody to run
back at the original level, and writing "cd ..", which leads to all
sorts of problems, becomes too tempting.
>> +'
>> +
>> test_expect_success 'basic' '
>> run_completion "git \"\"" &&
>> # built-in
>> @@ -228,4 +244,9 @@ test_expect_success 'general options plus command' '
>> test_completion "git --no-replace-objects check" "checkout "
>> '
>>
>> +test_expect_success 'send-email' '
>> + test_completion "git send-email --cov" "--cover-letter " &&
>> + test_completion "git send-email ma" "master "
>> +'
>> +
>> test_done
>> --
>> 1.7.12.1
>>
next prev parent reply other threads:[~2012-10-15 23:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 16:14 [PATCH] completion: add format-patch options to send-email Felipe Contreras
2012-10-15 22:48 ` SZEDER Gábor
2012-10-15 23:28 ` Junio C Hamano [this message]
2012-10-15 23:37 ` Felipe Contreras
2012-10-15 23:55 ` SZEDER Gábor
2012-10-15 23:57 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhapvuxgo.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).