Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] Make the largest pack the first one in the pack search queue
Date: Tue, 06 Mar 2012 19:21:17 -0800	[thread overview]
Message-ID: <7vhay1p042.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1331089308-16706-1-git-send-email-pclouds@gmail.com> ("Nguyễn	Thái Ngọc Duy"'s message of "Wed, 7 Mar 2012 10:01:48 +0700")

As the expected pay off from this change seems to be only based on a
hunch, it is hard for anybody to give useful comments on a patch
like this without benchmarks. As the implementation is more or less
trivial, the only thing anybody could say is "if changing the search
order is proved to be useful, the patch seems sane," but the "if"
part poses a lot bigger question than the patch itself.

At this late in the cycle, I would rather see a contributor with
many in-flight topics to start sifting his own existing topics into
the ones to be polished for the next release and the others to be
postponed for the next cycle, instead of adding yet more topics with
untied loose ends at this point.

Thanks.

      reply	other threads:[~2012-03-07  3:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07  3:01 [PATCH/RFC] Make the largest pack the first one in the pack search queue Nguyễn Thái Ngọc Duy
2012-03-07  3:21 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhay1p042.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox