From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Michael Lukashov <michael.lukashov@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Makefile: clarify definition of TEST_OBJS
Date: Sun, 28 Feb 2010 13:17:21 -0800 [thread overview]
Message-ID: <7vhbp1vz4u.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20100228091155.GB30143@progeny.tock
Jonathan Nieder <jrnieder@gmail.com> writes:
> Oddly enough, with or without this change the behavior of the Makefile
> is the same. Since TEST_PROGRAMS is defined with delayed evaluation,
> the value of
>
> TEST_OBJS := $(patsubst test-%$X,test-%.o,$(TEST_PROGRAMS))
>
> is independent of the value of $X when it is evaluated: the $X in the
> pattern and the $X in $(TEST_PROGRAMS) will simply always cancel out.
Ugh. That is what I missed. Thanks for explanation.
The mismerge fixed by [PATCH 1/2] comes from my rerere database, and
thanks to J6t's earlier "rerere forget" work, I managed to fix it in
preparation for the eventual merge to 'master'. I queued the fix-up
directly on 'next' as well.
prev parent reply other threads:[~2010-02-28 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 21:09 [PATCH] Makefile: fix compilation of test programs under MinGW environment Michael Lukashov
2010-02-27 21:31 ` Junio C Hamano
2010-02-27 21:40 ` Michael Lukashov
2010-02-27 22:15 ` Junio C Hamano
2010-02-27 23:03 ` Michael Lukashov
2010-02-28 9:03 ` [PATCH 1/2] Makefile: fix definition of $(TEST_PROGRAMS) on Windows Jonathan Nieder
2010-02-28 9:11 ` [PATCH 2/2] Makefile: clarify definition of TEST_OBJS Jonathan Nieder
2010-02-28 21:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhbp1vz4u.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=michael.lukashov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).