From: Junio C Hamano <gitster@pobox.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] git-gui: check whether systems nice command works or disable it
Date: Sun, 07 Feb 2010 16:21:40 -0800 [thread overview]
Message-ID: <7vhbps4lwr.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100207214755.GB3034@book.hvoigt.net> (Heiko Voigt's message of "Sun\, 7 Feb 2010 22\:47\:56 +0100")
Heiko Voigt <hvoigt@hvoigt.net> writes:
> This fixes issue 394 from msysgit. It seems that the Gnuwin32 project
> provides a nice command but it returns a "not implemented" error. To
> help users we now try to execute once and disable it in case it fails.
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> ---
>
> see: http://code.google.com/p/msysgit/issues/detail?id=394
> for more information.
>
> cheers Heiko
>
> git-gui/git-gui.sh | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> index 1fb3cbf..eec2dc9 100755
> --- a/git-gui/git-gui.sh
> +++ b/git-gui/git-gui.sh
> @@ -388,6 +388,9 @@ proc _lappend_nice {cmd_var} {
>
> if {![info exists _nice]} {
> set _nice [_which nice]
> + if {[catch {exec $_nice git version}]} {
> + set _nice {}
> + }
Where does the output from this "git version" invocation go?
> }
> if {$_nice ne {}} {
> lappend cmd $_nice
> --
> 1.7.0.rc1.7.gc0da5
next prev parent reply other threads:[~2010-02-08 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 21:47 [PATCH] git-gui: check whether systems nice command works or disable it Heiko Voigt
2010-02-08 0:21 ` Junio C Hamano [this message]
2010-02-08 15:56 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhbps4lwr.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).