Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Reilly Grant <reillyeon@qotw.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-p4: Avoid modules deprecated in Python 2.6.
Date: Wed, 26 Aug 2009 11:14:06 -0700	[thread overview]
Message-ID: <7vhbvucuj5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1251305536-25887-1-git-send-email-reillyeon@qotw.net> (Reilly Grant's message of "Wed\, 26 Aug 2009 09\:52\:16 -0700")

Reilly Grant <reillyeon@qotw.net> writes:

> The popen2, sha and sets modules are deprecated in Python 2.6 (sha in
> Python 2.5).  Both popen2 and sha are not actually used in git-p4.
> Replace usage of sets.Set with the builtin set object.

Does the code already rely on a feature not found in Python older than 2.4
before your patch?  Otherwise I would have liked to see the last sentence
like this:

    Replace usage of sets.Set with the builtin set object, which has
    been available since Python 2.4.

    This change makes the script unusable with Python older than 2.4,
    which was released in 2004. Hopefully nobody uses ancient 2.3.

So that I did not have to check myself to get a feel of how safe this
change is.

  reply	other threads:[~2009-08-26 18:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26 16:52 [PATCH] git-p4: Avoid modules deprecated in Python 2.6 Reilly Grant
2009-08-26 18:14 ` Junio C Hamano [this message]
2009-08-26 18:39   ` Reilly Grant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhbvucuj5.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=reillyeon@qotw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox