From: Junio C Hamano <gitster@pobox.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t8005: use more portable character encoding names
Date: Fri, 22 May 2009 09:22:46 -0700 [thread overview]
Message-ID: <7vhbzd85ux.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <WnZxv4G_GKTN4oHhxHO_HuQt0cTqurrqXf2HHDiHLAzdp7wC70aKuqDot7xQ1nG9C8_NASCL1_Q@cipher.nrlssc.navy.mil> (Brandon Casey's message of "Fri\, 22 May 2009 10\:25\:04 -0500")
Brandon Casey <casey@nrlssc.navy.mil> writes:
> ... I hesitate to send it since it does not actually allow any
> tests to pass which were previously failing for me. At least the utf-8 to
> UTF-8 shouldn't cause any harm. The shift-jis to SJIS seems to be commonly
> supported? at least IRIX 6.5 and Solaris as old as 7 recognize it, but the
> evidence is only empirical. Modern Solaris, and of course Linux recognize
> either.
Perhaps the test can be changed from using cp1251 (whatever that is) to
something more common (e.g. 8859-1)?
There was another more large-ish patch to the tests around this area
recently from you. I liked them but somehow failed to queue any of them
yet, sorry.
next prev parent reply other threads:[~2009-05-22 16:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 15:25 [PATCH] t8005: use more portable character encoding names Brandon Casey
2009-05-22 16:22 ` Junio C Hamano [this message]
2009-05-22 16:51 ` Brandon Casey
2009-05-22 23:04 ` Alex Riesen
2009-05-22 23:47 ` [PATCH 1/2] " Brandon Casey
2009-05-22 23:47 ` [PATCH 2/2] t8005: convert CP1251 character set to ISO8859-5 Brandon Casey
2009-05-23 1:02 ` Junio C Hamano
2009-05-23 1:06 ` Junio C Hamano
2009-05-25 9:20 ` Jeff King
2009-05-25 9:26 ` Jeff King
2009-05-26 14:56 ` Brandon Casey
2009-05-28 18:43 ` Jeff King
2009-05-26 14:57 ` Brandon Casey
2009-05-28 18:47 ` Jeff King
2009-05-26 22:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhbzd85ux.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).