From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/5] Add option for using a foreign VCS
Date: Wed, 25 Mar 2009 11:03:14 -0700 [thread overview]
Message-ID: <7vhc1h5vkt.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LNX.1.00.0903251042280.19665@iabervon.org
Daniel Barkalow <barkalow@iabervon.org> writes:
>> > - if (!prefixcmp(url, "rsync:")) {
>> > + if (remote && remote->foreign_vcs) {
>> > + } else if (!prefixcmp(url, "rsync:")) {
>>
>> if (...) {
>> ; /* empty */
>> } else ...
>
> I don't think I've ever tried writing an empty block for git before. It's
> braces containing a semicolon and comment? (Of course, the reason I wrote
> this one this way is so that the next patch could put two "+" lines in
> there and have no "-" lines)
Wasn't a serious "this has to be the final style" suggestion, but more
about "what do you mean by this? are you going to add more code here in
the later round?" question.
next prev parent reply other threads:[~2009-03-25 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 3:04 [PATCH 3/5] Add option for using a foreign VCS Daniel Barkalow
2009-03-25 6:49 ` Junio C Hamano
2009-03-25 16:20 ` Daniel Barkalow
2009-03-25 18:03 ` Junio C Hamano [this message]
2009-03-25 18:46 ` Daniel Barkalow
2009-03-25 18:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhc1h5vkt.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).