From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 1/2] fsck: HEAD is part of refs Date: Sat, 31 Jan 2009 16:57:10 -0800 Message-ID: <7vhc3f2cux.fsf@gitster.siamese.dyndns.org> References: <49814BA4.6030705@zytor.com> <7vfxj1eqh6.fsf@gitster.siamese.dyndns.org> <49822944.8000103@zytor.com> <20090129223529.GB1465@elte.hu> <20090129224357.GA18471@elte.hu> <498231EA.3030801@zytor.com> <7vvdrxd8jz.fsf@gitster.siamese.dyndns.org> <7veiylb1in.fsf_-_@gitster.siamese.dyndns.org> <20090201064520.6117@nanako3.lavabit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , "H. Peter Anvin" , Ingo Molnar , Git Mailing List To: Nanako Shiraishi X-From: git-owner@vger.kernel.org Sun Feb 01 01:58:47 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LTQfd-0004c0-NB for gcvg-git-2@gmane.org; Sun, 01 Feb 2009 01:58:46 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752681AbZBAA5U (ORCPT ); Sat, 31 Jan 2009 19:57:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752653AbZBAA5U (ORCPT ); Sat, 31 Jan 2009 19:57:20 -0500 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:44764 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbZBAA5T (ORCPT ); Sat, 31 Jan 2009 19:57:19 -0500 Received: from localhost.localdomain (unknown [127.0.0.1]) by b-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTP id 0F77B2A2EF; Sat, 31 Jan 2009 19:57:19 -0500 (EST) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by b-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTPSA id 1C5912A2ED; Sat, 31 Jan 2009 19:57:11 -0500 (EST) In-Reply-To: <20090201064520.6117@nanako3.lavabit.com> (Nanako Shiraishi's message of "Sun, 01 Feb 2009 06:45:20 +0900") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 468DC42E-EFFB-11DD-A4ED-F63E8D1D4FD0-77302942!a-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Nanako Shiraishi writes: > Quoting Junio C Hamano : > >> By default we looked at all refs but not HEAD. The only thing that >> made fsck not lose sight of comments that are only reachable from a >> detached HEAD was the reflog for the HEAD. >> >> This fixes it, with a new test. >> >> Signed-off-by: Junio C Hamano > > I think you meant to say commits, not comments. I'll amend when I fix the broken test J6t pointed out.