From: Junio C Hamano <gitster@pobox.com>
To: Stefan Karpinski <stefan.karpinski@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-cvsserver: handle CVS 'noop' command.
Date: Thu, 29 Jan 2009 15:46:17 -0800 [thread overview]
Message-ID: <7vhc3hd6ba.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <d4bc1a2a0901291539m636f0fc8s5d9280ce9b7d22b2@mail.gmail.com> (Stefan Karpinski's message of "Thu, 29 Jan 2009 15:39:23 -0800")
Stefan Karpinski <stefan.karpinski@gmail.com> writes:
> So apparently a response *is* expected. I'm not really familiar enough
> with CVS or git-cvsserver to determine what that means it should do,
> but I suspect from perusing the code that req_EMPTY is the appropriate
> action.
>
> Moreover, I've moved on from using git-cvsserver myself, having
> instead convinced my Windows-using compatriots to use msysgit instead.
> So if you feel that this change is unwarranted, feel free to just drop
> it.
Because the issue currently has our attention, and we think we know that
the code does not do the right thing currently, and that we are fairly
sure that the right thing is to do req_EMPTY, I'd rather see a tested fix
applied so that we can forget about it ;-)
It's good that you moved your people to native git environment, but if you
have an environment where you can test the fix still lying around, I'd
appreciate a quick test and resubmit.
next prev parent reply other threads:[~2009-01-29 23:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1232144521-21947-1-git-send-email-stefan.karpinski@gmail.com>
[not found] ` <1232144521-21947-2-git-send-email-stefan.karpinski@gmail.com>
2009-01-23 5:43 ` [PATCH] git-cvsserver: run post-update hook *after* update Stefan Karpinski
2009-01-23 8:00 ` Junio C Hamano
2009-01-29 21:58 ` Stefan Karpinski
2009-01-29 22:48 ` Junio C Hamano
2009-01-29 23:26 ` Stefan Karpinski
2009-01-29 22:56 ` Andy Parkins
2009-01-29 21:35 ` [PATCH] git-cvsserver: handle CVS 'noop' command Stefan Karpinski
2009-01-29 22:45 ` Junio C Hamano
2009-01-29 23:39 ` Stefan Karpinski
2009-01-29 23:46 ` Junio C Hamano [this message]
2009-01-30 1:12 ` Stefan Karpinski
2009-01-30 1:32 ` Martin Langhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhc3hd6ba.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=stefan.karpinski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).