From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Maciej Pasternacki <maciej@pasternacki.net>, git@vger.kernel.org
Subject: Re: [PATCH] -C/--chdir command line option
Date: Sun, 19 Oct 2008 22:41:04 -0700 [thread overview]
Message-ID: <7vhc774ydr.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vr66b50gy.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 19 Oct 2008 21:55:57 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> The only excuse I remember seeing in the thread was that "make has '-C'
> option, so let's have it, because it is similar", which does not justfiy
> addition of that option to git at all to me.
Just after having said that "make has it, so let's have it ourselves, too"
is a non-excuse to any feature bloat, one thing I could accept a patch to
imitate what "make" does, especially if we are going to actually clean up
the startup sequence like we have discussed sometime ago to fix breakage
around --work-tree, is to have VAR=VAL (e.g. "make CFLAGS=-O2") on the
command line. We could use that syntax to allow configuration variables
to be overridden, like so:
$ git core.whitespace=cr-at-eol log -p master..next
I wouldn't however suggest allowing the syntax to set environment
variables, like:
$ git GIT_AUTHOR_NAME="A U Thor" commit
as this is something your shell lets you do easily, i.e:
$ GIT_AUTHOR_NAME="A U Thor" git commit
But overriding some configuration variables for a single command
invocation is not something you can do without actually editing the
configuration file for some variables, so the former would be justified.
next prev parent reply other threads:[~2008-10-20 5:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 0:02 [PATCH] -C/--chdir command line option Maciej Pasternacki
2008-10-19 13:17 ` Jeff King
2008-10-19 13:47 ` Maciej Pasternacki
2008-10-19 14:16 ` Jeff King
2008-10-19 15:24 ` Maciej Pasternacki
2008-10-20 4:55 ` Junio C Hamano
2008-10-20 5:41 ` Junio C Hamano [this message]
2008-10-20 6:26 ` Alex Riesen
2008-10-20 12:57 ` Michael J Gruber
2008-10-20 13:59 ` Nguyen Thai Ngoc Duy
[not found] <DDFCD680-C477-4BE5-AB71-3F26048E26D1@pasternacki.net>
2008-10-20 7:28 ` Maciej Pasternacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhc774ydr.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=maciej@pasternacki.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).