From: Junio C Hamano <gitster@pobox.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: "Robin H. Johnson" <robbat2@gentoo.org>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: On PPC64, the parsing of integers on the commandline is bitshifted.
Date: Thu, 07 Aug 2008 14:42:29 -0700 [thread overview]
Message-ID: <7vhc9wijsq.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <CxVxAoKmEQsrgFdHEvL0sjkgBBIVZ3Zvsl0pPSuDSfH_8xM8NOSGfw@cipher.nrlssc.navy.mil> (Brandon Casey's message of "Thu, 07 Aug 2008 16:34:00 -0500")
Brandon Casey <casey@nrlssc.navy.mil> writes:
> Brandon Casey wrote:
>> Robin H. Johnson wrote:
>>> In a 64-bit userland, big-endian environment, the parser gets integers
>>> wrong.
>>
>> There is a fix on master. Can you try that out?
>> Unfortunately, looks like it did not make it into 1.5.6.5
>
> Also, just so you know, it is test-parse-options.c that is broken, not
> the parsing code. So, the rest of git should be using an int with
> OPT_INTEGER() and should operate correctly.
Yup, that is why it is not on 'maint' --- but somebody should audit the
parse_options() users in the real programs to make sure that there is no
similar breakages, namely, giving a pointer to long to OPT_INTEGER().
next prev parent reply other threads:[~2008-08-07 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 20:31 On PPC64, the parsing of integers on the commandline is bitshifted Robin H. Johnson
2008-08-07 21:26 ` Brandon Casey
2008-08-07 21:34 ` Brandon Casey
2008-08-07 21:42 ` Junio C Hamano [this message]
2008-08-08 8:38 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhc9wijsq.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox