From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] diff --relative: output paths as relative to the current subdirectory
Date: Tue, 12 Feb 2008 17:19:29 -0800 [thread overview]
Message-ID: <7vhcgdzm8u.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0802121604310.2920@woody.linux-foundation.org> (Linus Torvalds's message of "Tue, 12 Feb 2008 16:09:18 -0800 (PST)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> So I simply don't think that we should assume a working directory for any
> basic git operation, unless that operation fundamentally needs one because
> it's only defined for a system with working directories (which is fairly
> rare, but obviously happens: "git reset --hard", "git pull/merge", "git
> checkout" etc).
Yeah, but that begs for a larger design-level question.
Instead of treating "diff --relative=drivers/ a..b", as a
special case, shouldn't we have a more general "I may be in a
bare repository, but please pretend that my prefix were this
path" option?
$ git --prefix=drivers/ diff --relative a..b -- scsi
$ git --prefix=drivers/scsi log a..b .
Of course, if you are truly in a bare repository and if you did
an operation that wants a work tree, you would get mostly
useless results, e.g.
$ git --prefix=fs/ diff v2.6.24 -- ext3
will give you tons of whole-file removals.
I suspect that a lot of existing code assumes a non NULL prefix
automatically means we have work tree, which needs to be fixed,
if we go this route, though.
next prev parent reply other threads:[~2008-02-13 1:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 22:26 [PATCH/RFC] diff --relative: output paths as relative to the current subdirectory Junio C Hamano
2008-02-12 23:33 ` Linus Torvalds
2008-02-12 23:43 ` Junio C Hamano
2008-02-12 23:53 ` Linus Torvalds
2008-02-13 0:09 ` Linus Torvalds
2008-02-13 1:19 ` Junio C Hamano [this message]
2008-02-13 8:33 ` Junio C Hamano
2008-02-13 0:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhcgdzm8u.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).