From: Junio C Hamano <gitster@pobox.com>
To: Gustaf Hendeby <hendeby@isy.liu.se>
Cc: luciano@eurotux.com, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2] Make git send-email accept $EDITOR with arguments
Date: Fri, 21 Dec 2007 09:02:44 -0800 [thread overview]
Message-ID: <7vhcic9e17.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1198237002-21470-1-git-send-email-hendeby@isy.liu.se> (Gustaf Hendeby's message of "Fri, 21 Dec 2007 12:36:42 +0100")
Gustaf Hendeby <hendeby@isy.liu.se> writes:
> Junio, even if this is technically not a bug fix, it would be nice to
> get this fix into the 1.5.4 so that the usage of $EDITOR becomes more
> consistent throughout git.
I can buy that, but at least a single line comment in front of that
system() explaining why this is safe to do so would be beneficial. I
suspect that somebody would propose moving $compse_filename inside
$GIT_DIR, now people realized $compose_filename is currently "./.msg.$$",
and $GIT_DIR could be anything. Quotemeta would probably be better as the
code you are touching won't be affected by a future change to the value of
that constant defined far away in the source.
next prev parent reply other threads:[~2007-12-21 17:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 20:14 [PATCH] Make git send-email accept $EDITOR with arguments Gustaf Hendeby
2007-12-20 20:32 ` Luciano Rocha
2007-12-21 11:36 ` [PATCH v2] " Gustaf Hendeby
2007-12-21 13:34 ` Jeff King
2007-12-21 15:23 ` Gustaf Hendeby
2007-12-21 19:23 ` Jeff King
2007-12-21 21:07 ` Gustaf Hendeby
2007-12-21 21:17 ` Junio C Hamano
2007-12-22 0:40 ` [PATCH v3] " Gustaf Hendeby
2007-12-22 1:05 ` Junio C Hamano
2007-12-22 8:47 ` Gustaf Hendeby
2007-12-21 17:02 ` Junio C Hamano [this message]
2007-12-22 0:43 ` [PATCH] Move git send-email cover letter temporary file to $GIT_DIR Gustaf Hendeby
2007-12-22 1:09 ` Junio C Hamano
2007-12-22 1:18 ` David Symonds
2007-12-22 6:49 ` Junio C Hamano
2007-12-22 7:04 ` David Symonds
2007-12-22 8:52 ` Junio C Hamano
2007-12-22 9:13 ` Gustaf Hendeby
-- strict thread matches above, loose matches on Subject: below --
2007-12-21 21:37 [PATCH v2] Make git send-email accept $EDITOR with arguments Gustaf Hendeby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhcic9e17.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hendeby@isy.liu.se \
--cc=luciano@eurotux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).