From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Christian Couder <chriscool@tuxfamily.org>,
git@vger.kernel.org
Subject: Re: git-browse-help?
Date: Sat, 15 Dec 2007 11:25:59 -0800 [thread overview]
Message-ID: <7vhcijn4jc.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071215111154.GB3447@coredump.intra.peff.net> (Jeff King's message of "Sat, 15 Dec 2007 06:11:54 -0500")
Jeff King <peff@peff.net> writes:
> BTW, Junio, I remember discussion a long time ago about doing:
>
> cover letter
> -- >8 --
> commit
> ---
> diff
>
> versus
>
> commit
> ---
> cover letter
> diff
>
> and I recall that you did not have a strong preference. I have started
> using the former, as I find it a bit more convenient to write (and I
> think it is more readable when you are following up a discussion rather
> than writing a real cover letter or commenting on the patch).
Yeah, and it is not too inconvenient to trim it off if you use "am -i"
or "commit --amend". An added bonus is unlike the "top-post" style, the
cover material is available when editing the final log message, so I
actually slightly prefer "cover -- >8 -- log --- patch" myself.
next prev parent reply other threads:[~2007-12-15 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 9:28 git-browse-help? Jeff King
2007-12-14 17:38 ` git-browse-help? Junio C Hamano
2007-12-15 10:08 ` git-browse-help? Jeff King
2007-12-15 11:01 ` git-browse-help? Jeff King
2007-12-15 11:11 ` git-browse-help? Jeff King
2007-12-15 19:25 ` Junio C Hamano [this message]
2007-12-15 22:25 ` git-browse-help? Shawn O. Pearce
2007-12-15 19:26 ` git-browse-help? Junio C Hamano
2007-12-16 7:21 ` git-browse-help? Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhcijn4jc.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).