From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Allow ':/' syntax to work with save_commit_buffer == 0 Date: Mon, 03 Dec 2007 13:34:05 -0800 Message-ID: <7vhcizh38y.fsf@gitster.siamese.dyndns.org> References: <20071203043258.GA16658@coredump.intra.peff.net> <20071203173022.GA19219@coredump.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff King , git@vger.kernel.org, gitster@pobox.com To: Johannes Schindelin X-From: git-owner@vger.kernel.org Mon Dec 03 22:34:39 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IzIvz-0006v0-I3 for gcvg-git-2@gmane.org; Mon, 03 Dec 2007 22:34:35 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750858AbXLCVeO (ORCPT ); Mon, 3 Dec 2007 16:34:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750818AbXLCVeO (ORCPT ); Mon, 3 Dec 2007 16:34:14 -0500 Received: from sceptre.pobox.com ([207.106.133.20]:51403 "EHLO sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbXLCVeN (ORCPT ); Mon, 3 Dec 2007 16:34:13 -0500 Received: from sceptre (localhost.localdomain [127.0.0.1]) by sceptre.pobox.com (Postfix) with ESMTP id 512032FA; Mon, 3 Dec 2007 16:34:34 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id BE2B59C918; Mon, 3 Dec 2007 16:34:29 -0500 (EST) In-Reply-To: (Johannes Schindelin's message of "Mon, 3 Dec 2007 18:42:39 +0000 (GMT)") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Johannes Schindelin writes: > Signed-off-by: Johannes Schindelin > --- > > On Mon, 3 Dec 2007, Jeff King wrote: > > > On Mon, Dec 03, 2007 at 10:55:15AM +0000, Johannes Schindelin wrote: > > > > > But then, my patch also works when save_commit_buffer == 0. > > > But I can refactor this into its own patch, since it really is > > > a separate issue. > > > > Agreed. > > Here we go. The log message is a bit lacking. I would have expected "git-show command can take ':/prefix' as an argument to name a commit whose subject begins with the prefix, but git-foobar command didn't and instead errored out. This fixes it so that ':/prefix' syntax can be used for any command that wants to take a commit object name".