From: Junio C Hamano <gitster@pobox.com>
To: Guido Ostkamp <git@ostkamp.fastmail.fm>
Cc: "Björn Steinbrink" <B.Steinbrink@gmx.de>,
raa.lkml@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] Fix "identifier redeclared" compilation error with SUN cc
Date: Tue, 20 Nov 2007 00:30:57 -0800 [thread overview]
Message-ID: <7vhcjhl3ni.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0711191847550.7957@bianca.dialin.t-online.de> (Guido Ostkamp's message of "Mon, 19 Nov 2007 18:51:00 +0100 (CET)")
Guido Ostkamp <git@ostkamp.fastmail.fm> writes:
>> ...
>> How about doing it this way?
>
> it looks ok on Solaris. I assembled the following patch from your
> posting, could you please include it?
>
>
> Signed-off-by: Guido Ostkamp <git@ostkamp.fastmail.fm>
I knew it would work on Solaris with gcc and cc that do not
understand flexible array members, but I am a bit worried about
other environments, where flexible array members are properly
supported. They've been happily using member[] but with the
patch they suddenly start wasting a cell.
But we should do this sooner rather than later to find out any
breakage, and give people on platforms with a cc that supports
flexible array members and care about wasted memory enough time
to send patches to support their compiler in the way similar to
how gcc is supported.
But I cannot use your message with whitespace-broken patch (note
"format=flawed") and insufficient commit log message, which
means I have to do this myself. Not tonight...
next prev parent reply other threads:[~2007-11-20 8:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 20:31 [PATCH] Fix Solaris Workshop Compiler issues Guido Ostkamp
2007-11-14 20:47 ` Alex Riesen
2007-11-14 21:25 ` Junio C Hamano
2007-11-14 23:21 ` Guido Ostkamp
2007-11-14 23:28 ` Alex Riesen
2007-11-15 0:17 ` Björn Steinbrink
2007-11-15 0:30 ` Junio C Hamano
2007-11-15 0:44 ` Björn Steinbrink
2007-11-15 0:46 ` Junio C Hamano
2007-11-15 0:50 ` Björn Steinbrink
2007-11-15 1:15 ` [PATCH] Fix "identifier redeclared" compilation error with SUN cc Björn Steinbrink
2007-11-15 22:00 ` Guido Ostkamp
2007-11-15 22:15 ` Junio C Hamano
2007-11-15 22:28 ` Guido Ostkamp
2007-11-16 18:59 ` [PATCH] Add mkdtemp() workaround for Sun Solaris 10 Guido Ostkamp
2007-11-17 0:33 ` [RFH] Solaris portability Junio C Hamano
2007-11-18 12:08 ` Guido Ostkamp
2007-11-18 17:46 ` Junio C Hamano
2007-11-16 4:58 ` [PATCH] Fix "identifier redeclared" compilation error with SUN cc Junio C Hamano
2007-11-16 12:55 ` Björn Steinbrink
2007-11-19 17:51 ` Guido Ostkamp
2007-11-20 8:30 ` Junio C Hamano [this message]
2007-11-20 17:28 ` Guido Ostkamp
2007-11-20 18:06 ` Guido Ostkamp
2007-11-20 18:26 ` Martin Mares
2007-11-20 20:08 ` Junio C Hamano
2007-11-20 20:09 ` Martin Mares
2007-11-15 0:44 ` [PATCH] Fix Solaris Workshop Compiler issues Linus Torvalds
2007-11-15 1:21 ` David Kastrup
2007-11-15 1:53 ` Linus Torvalds
2007-11-15 3:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhcjhl3ni.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=B.Steinbrink@gmx.de \
--cc=git@ostkamp.fastmail.fm \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).