From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Daniel Barkalow <barkalow@iabervon.org>,
Pierre Habouzit <madcoder@debian.org>,
Nicolas Pitre <nico@cam.org>, Git ML <git@vger.kernel.org>
Subject: Re: [bug in next ?] git-fetch/git-push issue
Date: Mon, 05 Nov 2007 15:22:17 -0800 [thread overview]
Message-ID: <7vhck0mg5y.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071105225540.GA10988@sigill.intra.peff.net> (Jeff King's message of "Mon, 5 Nov 2007 17:55:41 -0500")
Jeff King <peff@peff.net> writes:
> Which I guess is what you were trying to accomplish by removing the
> peer_ref, though I think that doesn't distinguish between "didn't match
> a remote ref" and "had an error." Perhaps we just need an error flag in
> the ref struct?
I agree that makes the most sense.
As Steffen has been advocating on another thread, depending on
your workflow, you do not care about some classes of push errors
per pushed refs. The update of the remote and local tracking
refs should be done in sync (i.e. if the remote wasn't updated,
never update the corresponding local), but it can depend on the
nature of the failure if a failure to update a remote ref should
result in the non-zero exit status from git-push as a whole.
And to implement that, per-ref error flag would be a good way to
go, methinks.
next prev parent reply other threads:[~2007-11-05 23:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 17:56 [bug in next ?] git-fetch/git-push issue Pierre Habouzit
2007-11-05 18:17 ` Daniel Barkalow
2007-11-05 21:07 ` Jeff King
2007-11-05 21:41 ` Daniel Barkalow
2007-11-05 22:55 ` Jeff King
2007-11-05 23:22 ` Junio C Hamano [this message]
2007-11-05 23:59 ` Daniel Barkalow
2007-11-05 23:46 ` Daniel Barkalow
2007-11-06 3:26 ` Jeff King
2007-11-05 18:19 ` Pierre Habouzit
2007-11-06 17:56 ` Pierre Habouzit
2007-11-06 18:09 ` Jeff King
2007-11-06 18:23 ` Junio C Hamano
2007-11-06 18:41 ` Jeff King
2007-11-06 19:37 ` Pierre Habouzit
2007-11-07 15:11 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhck0mg5y.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=nico@cam.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).