From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.176.0/21 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 From: Junio C Hamano Subject: Re: WARNING: THIS PATCH CAN BREAK YOUR REPO, was Re: [PATCH 2/3] Only repack active packs by skipping over kept packs. Date: Mon, 30 Oct 2006 15:24:42 -0800 Message-ID: <7vhcxltmit.fsf@assigned-by-dhcp.cox.net> References: <20061029093754.GD3847@spearce.org> <20061030202611.GA5775@spearce.org> <20061030205200.GA20236@delft.aura.cs.cmu.edu> <7v3b95wjmg.fsf@assigned-by-dhcp.cox.net> <20061030225500.GG3617@delft.aura.cs.cmu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii NNTP-Posting-Date: Mon, 30 Oct 2006 23:24:58 +0000 (UTC) Cc: git@vger.kernel.org Return-path: Envelope-to: gcvg-git@gmane.org In-Reply-To: <20061030225500.GG3617@delft.aura.cs.cmu.edu> (Jan Harkes's message of "Mon, 30 Oct 2006 17:55:00 -0500") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GegUq-0004xA-Ka for gcvg-git@gmane.org; Tue, 31 Oct 2006 00:24:49 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161405AbWJ3XYp (ORCPT ); Mon, 30 Oct 2006 18:24:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161449AbWJ3XYp (ORCPT ); Mon, 30 Oct 2006 18:24:45 -0500 Received: from fed1rmmtao09.cox.net ([68.230.241.30]:4076 "EHLO fed1rmmtao09.cox.net") by vger.kernel.org with ESMTP id S1161405AbWJ3XYo (ORCPT ); Mon, 30 Oct 2006 18:24:44 -0500 Received: from fed1rmimpo01.cox.net ([70.169.32.71]) by fed1rmmtao09.cox.net (InterMail vM.6.01.06.01 201-2131-130-101-20060113) with ESMTP id <20061030232443.TDCN16798.fed1rmmtao09.cox.net@fed1rmimpo01.cox.net>; Mon, 30 Oct 2006 18:24:43 -0500 Received: from assigned-by-dhcp.cox.net ([68.5.247.80]) by fed1rmimpo01.cox.net with bizsmtp id gnQP1V00S1kojtg0000000 Mon, 30 Oct 2006 18:24:24 -0500 To: Jan Harkes Sender: git-owner@vger.kernel.org Jan Harkes writes: > On Mon, Oct 30, 2006 at 01:59:03PM -0800, Junio C Hamano wrote: >> Jan Harkes writes: >> >> > The following patch does fix the problem Nicolas reported, but for some >> > reason I'm still getting only 102 objects (only tags and the commits >> > they refer to?) with your test. >> >> One potential downside of this is that this makes an obscure but >> useful "gitk --unpacked" useless (robs performance). >> >> http://thread.gmane.org/gmane.comp.version-control.git/19197/focus=19207 > > If I use 'git fetch' followed later on by a 'git fetch -k', the result > from --unpacked would not include the unpacked objects created by the > first fetch. Although it may have been fast, it seems to be somewhat > counter-intuitive. > >> But other than that, I think it is an Ok change. The original >> semantics of --unpacked (with or without "pretend as if objects >> in this pack are loose") were, eh, "strange". > > Do you need a resend with a proper 'Signed-Off-By' line? Oh, I was planning to write a fairly detailed explanation myself, but the description with S-o-b by the original author would certainly be more appropriate. Thanks.