git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Timo Hirvonen <tihirvon@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Print empty line between raw, stat, summary and patch
Date: Tue, 27 Jun 2006 11:03:24 -0700	[thread overview]
Message-ID: <7vhd268oib.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060627150917.7eabde58.tihirvon@gmail.com> (Timo Hirvonen's message of "Tue, 27 Jun 2006 15:09:17 +0300")

Timo Hirvonen <tihirvon@gmail.com> writes:

> Signed-off-by: Timo Hirvonen <tihirvon@gmail.com>
> ---
>
>   Should we print options->line_termination instead of \n between all
>   fields?

I personally do not think it is a big deal since combination of
stat, summary and patch are primarily for human consumption, but
somebody might want to write a frontend GUI on top of this
output and having an easy way to seperate the parts for machine
consumption might be helpful.

>   The old code didn't support as many combinations of raw,
>   stat, summary and patch so I'm not 100% sure about this.

Think of it as an opportunity to come up with the most sensible
without having to worry about backward compatibility ;-)  I'll
let you know what I think after I stare at its output for some
time.

Thanks.

      reply	other threads:[~2006-06-27 18:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-27 12:09 [PATCH] Print empty line between raw, stat, summary and patch Timo Hirvonen
2006-06-27 18:03 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhd268oib.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=tihirvon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).