From: Junio C Hamano <junkio@cox.net>
To: "Santi Béjar" <sbejar@gmail.com>
Cc: "Jan-Benedict Glaw" <jbglaw@lug-owl.de>,
git@vger.kernel.org, "Karl Hasselström" <kha@treskal.com>
Subject: Re: [PATCH] Reintroduce svn pools to solve the memory leak.
Date: Mon, 27 Mar 2006 10:16:58 -0800 [thread overview]
Message-ID: <7vhd5joiqt.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <8aa486160603270326i3a8ddcfau61ca84cdac036ff9@mail.gmail.com> (Santi Béjar's message of "Mon, 27 Mar 2006 13:26:01 +0200")
"Santi Béjar" <sbejar@gmail.com> writes:
> On 3/24/06, Santi Béjar <sbejar@gmail.com> wrote:
>> Jan-Benedict Glaw <jbglaw@lug-owl.de> writes:
>>
>> diff-tree 4802426... (from 525c0d7...)
>> Author: Karl Hasselström <kha@treskal.com>
>> Date: Sun Feb 26 06:11:27 2006 +0100
>>
>> svnimport: Convert executable flag
>>
>> Convert the svn:executable property to file mode 755 when converting
>> an SVN repository to GIT.
>>
>> Signed-off-by: Karl Hasselström <kha@treskal.com>
>> Signed-off-by: Junio C Hamano <junkio@cox.net>
>>
>> :100755 100755 ee2940f... 6603b96... M git-svnimport.perl
>
> And this patch fixes my problems.
Jan-Benedict, thanks for pinpointing the regression, and Santi,
thanks for the patch.
I should have looked a bit more closely when applying the patch
-- it is clear that the patch is doing more than what its log
says. My fault.
Karl, were there other reasons you needed to disable the pool
here (maybe to work around a problem with incompatible version
of SVN module)? I see some other uses of SVN::Pool still there
in the code, so I am assuming this was a simple typo, but just
in case...
next prev parent reply other threads:[~2006-03-27 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-27 11:26 [PATCH] Reintroduce svn pools to solve the memory leak Santi Béjar
2006-03-27 18:16 ` Junio C Hamano [this message]
2006-03-28 8:10 ` Jan-Benedict Glaw
2006-03-28 12:20 ` Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhd5joiqt.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=jbglaw@lug-owl.de \
--cc=kha@treskal.com \
--cc=sbejar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox